fix symlinks - #89
Conversation
|
6a9f951 requires bumping the required version of node to 14.14.0. Without this change, the previous behavior was failing to delete the symlink on disk, but showing it as gone in the application. With this change, the symlink is deleted, and the linked directory is preserved. It's probably also worthwhile to de-clutter |
markhughes
left a comment
markhughes
left a comment
There was a problem hiding this comment.
Thanks for the contribution, really appreciate it!
| "private": true, | ||
| "engines": { | ||
| "node": ">= 12.10.0" | ||
| "node": ">= 14.14.0" |
There was a problem hiding this comment.
Happy to raise this, but we'll need to do a major version update, i'll add that in
There was a problem hiding this comment.
Makes sense. Do you think you'd do a major version update with the three PRs I submitted today? I was planning to use Droppy for a hobby project, which is why I was testing and fixing things. Just trying to gauge if I should do a temporary workaround in my other project or not. Thanks!
There was a problem hiding this comment.
We can sort it out quickly I'm just a bit busy with work lately :) I'll look more in depth soon
There was a problem hiding this comment.
No problem, not trying to rush you. Not sure if this is the best place for this conversation, but some thoughts:
I'm not sure what my availability will be in the near future, but just so we aren't overlapping on work here, I was going to focus on more bug fixes before considering working on new features. For bug fixes, I was thinking these three would be next: #92, #74 and #18. As for features, the most impactful one (in my opinion) is #16, so I might switch to that at some point.
Longer term I might look into adding more testing to support a UI or framework overhaul. Some clearer documentation for contributing/dev might be nice too, there seems to be some strewn about tooling that isn't necessarily used and old documentation from the legacy project? I saw that some things were kept for reference, and potentially to be fixed (like docker builds, which I am happy to do at some point). It might be worth considering taking a "snapshot" of that with a branch for reference, then dump any dead code/docs.
2 participants
See silverwind/droppy#442 for context. I tested these changes and they work, with this commit symlinks will now work.
This is my first contribution, and I am still getting familiar with the project. Please let me know if there is an up to date documentation for contributing and testing.